Add -isystem to make / pkgconfig flags#1470
Open
keith wants to merge 1 commit intobazel-contrib:mainfrom
Open
Conversation
Previously this logic special cased `--sysroot` as an arugment that had to be passed with the compiler because some configure scripts didn't add CFLAGS to the configure steps. This same logic needs to apply to any `-isystem` flags set by the toolchain for the same reason. Headers that the toolchain requires with `-isystem` (without any deps) can contain things needed for configure scripts to produce valid results. For example they can contain glibc + sys/types.h etc, which is used by make's build scripts to determine if it needs to typedef any standard types.
cerisier
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this logic special cased
--sysrootas an arugment that hadto be passed with the compiler because some configure scripts didn't add
CFLAGS to the configure steps. This same logic needs to apply to any
-isystemflags set by the toolchain for the same reason. Headers thatthe toolchain requires with
-isystem(without any deps) can containthings needed for configure scripts to produce valid results. For
example they can contain glibc + sys/types.h etc, which is used by
make's build scripts to determine if it needs to typedef any standard
types.