Skip to content

Add support for platform-specific requirements #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for platform-specific requirements #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion mypy/private/types.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,17 @@ def _render_types_bzl(rctx, types):
content += "}\n"
return content

def _get_requirements(rctx):
if rctx.attr.requirements_linux and "linux" in rctx.os.name:
return rctx.read(rctx.attr.requirements_linux)
if rctx.attr.requirements_windows and "windows" in rctx.os.name:
return rctx.read(rctx.attr.requirements_windows)
if rctx.attr.requirements_darwin and "mac os" in rctx.os.name:
return rctx.read(rctx.attr.requirements_darwin)
return rctx.read(rctx.attr.requirements_txt)

def _generate_impl(rctx):
contents = rctx.read(rctx.attr.requirements_txt)
contents = _get_requirements(rctx)

types = []

Expand Down Expand Up @@ -73,6 +82,9 @@ generate = repository_rule(
attrs = {
"pip_requirements": attr.label(),
"requirements_txt": attr.label(allow_single_file = True),
"requirements_darwin": attr.label(allow_single_file = True),
"requirements_linux": attr.label(allow_single_file = True),
"requirements_windows": attr.label(allow_single_file = True),
"exclude_requirements": attr.string_list(default = []),
},
)
17 changes: 16 additions & 1 deletion mypy/types.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,20 @@ requirements = tag_class(
attrs = {
"name": attr.string(),
"pip_requirements": attr.label(),
"requirements_txt": attr.label(mandatory = True, allow_single_file = True),
"requirements_txt": attr.label(allow_single_file = True),
"exclude_requirements": attr.string_list(default = [], mandatory = False),
"requirements_darwin": attr.label(
allow_single_file = True,
doc = "MacOS only version of requirements_txt.",
),
"requirements_linux": attr.label(
allow_single_file = True,
doc = "Linux only version of requirements_txt.",
),
"requirements_windows": attr.label(
allow_single_file = True,
doc = "Windows only version of requirements_txt.",
),
},
)

Expand All @@ -18,6 +30,9 @@ def _extension(module_ctx):
name = tag.name,
pip_requirements = tag.pip_requirements,
requirements_txt = tag.requirements_txt,
requirements_darwin = tag.requirements_darwin,
requirements_linux = tag.requirements_linux,
requirements_windows = tag.requirements_windows,
exclude_requirements = tag.exclude_requirements,
)

Expand Down