Skip to content

Update mypy config file examples to use Label #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update mypy config file examples to use Label #115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,13 @@ mypy's behavior may be customized using a [mypy config file](https://mypy.readth

```starlark
mypy_aspect = mypy(
mypy_ini = "@@//:mypy.ini",
mypy_ini = Label("//:mypy.ini"),
types = types,
)
```

> [!NOTE]
> The label passed to `mypy_ini` needs to be absolute (a prefix of `@@` means the root repo).
> The label passed to `mypy_ini` is used across modules, so ensure you pass a `Label` (will be qualified relative to construction location) and not a regular string.

> [!NOTE]
> mypy.ini files should likely contain the following lines to suppress type-checking 3rd party modules.
Expand Down Expand Up @@ -107,7 +107,7 @@ And in your `aspects.bzl` (or similar) file:
load("@rules_mypy//mypy:mypy.bzl", "mypy")

mypy_aspect = mypy(
mypy_cli = ":mypy_cli",
mypy_cli = Label(":mypy_cli"),
types = types,
)
```
Expand Down