Simplify env #90
Draft
Simplify env #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonchinn178
force-pushed
the
simplify-env
branch
4 times, most recently
from
30bd553 to
d0113b6
Compare
brandonchinn178
force-pushed
the
simplify-env
branch
from
d0113b6 to
b6287a6
Compare
keith
reviewed
Jul 7, 2025
brandonchinn178
force-pushed
the
simplify-env
branch
7 times, most recently
from
44b9174 to
32e6877
Compare
brandonchinn178
force-pushed
the
simplify-env
branch
from
32e6877 to
4d21d3f
Compare
brandonchinn178
commented
Aug 11, 2025
Comment on lines
+52
to
+70
| DEP_TYPE_NORMAL = "normal" | ||
| DEP_TYPE_OVERRIDDEN = "overridden" # a dep that has a stub library overriding it | ||
| DEP_TYPE_STUB = "stub" | ||
|
|
||
| def _get_deps(ctx): | ||
| all_deps = [] | ||
| stub_mapping = { | ||
| base_dep.label: stub_dep | ||
| for base_dep, stub_dep in zip(ctx.attr._stubs_keys, ctx.attr._stubs_values) | ||
| } | ||
|
|
||
| for dep in ctx.rule.attr.deps: | ||
| if dep.label in stub_mapping: | ||
| all_deps.append((dep, DEP_TYPE_OVERRIDDEN)) | ||
| all_deps.append((stub_mapping[dep.label], DEP_TYPE_STUB)) | ||
| else: | ||
| all_deps.append((dep, DEP_TYPE_NORMAL)) | ||
|
|
||
| return all_deps |
There was a problem hiding this comment.
TODO: This should be able to go away. Just put all deps into PYTHONPATH and let mypy look for the stub library over the real library
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #89, the stubs libraries are put in PYTHONPATH, but other external deps are still in MYPYPATH. Now, we can just put everything into PYTHONPATH, and remove the logic to skip adding external deps if the stub library is added, since mypy already has the logic to load
types-foooverfoo.Also includes refactoring the MYPYPATH logic to be simpler + more readable. There are probably edge cases that are dropped in the refactoring, but I think we can find regressions + add test cases as we go