Skip to content

fix: minor typos in warning messages #3833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbedard merged 1 commit into from
May 26, 2025
Merged

fix: minor typos in warning messages #3833

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nodejs/repositories.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -444,7 +444,7 @@ def node_repositories(**kwargs):
print("""\
WARNING: node_repositories is deprecated; use nodejs_repositories instead.

If your are not calling node_repositories directly you may need to upgrade to rules_js 2.x to suppress this warning.
If you are not calling node_repositories directly you may need to upgrade to rules_js 2.x to suppress this warning.
""")

nodejs_repositories(**kwargs)
Expand Down
4 changes: 2 additions & 2 deletions nodejs/toolchain.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,7 @@ def nodejs_toolchain(
print("""\
WARNING: target_tool attribute of nodejs_toolchain is deprecated; use node instead of target_tool.

If your are not calling nodejs_toolchain directly you may need to upgrade to rules_js 2.x to suppress this warning.
If you are not calling nodejs_toolchain directly you may need to upgrade to rules_js 2.x to suppress this warning.
""")
node = target_tool

Expand Down Expand Up @@ -258,6 +258,6 @@ def node_toolchain(**kwargs):
print("""\
WARNING: node_toolchain is deprecated; use nodejs_toolchain instead.

If your are not calling node_toolchain directly you may need to upgrade to rules_js 2.x to suppress this warning.
If you are not calling node_toolchain directly you may need to upgrade to rules_js 2.x to suppress this warning.
""")
nodejs_toolchain(**kwargs)