Skip to content

fix: ensure bzl_library targets are correct#846

Open
alexeagle wants to merge 4 commits intomainfrom
stardocs
Open

fix: ensure bzl_library targets are correct#846
alexeagle wants to merge 4 commits intomainfrom
stardocs

Conversation

@alexeagle
Copy link
Collaborator

Workaround bazelbuild/bazel-skylib#568

Allows us to guarantee stardoc can run across the graph.

Also:
publish a docs.tar.gz file on releases, so BCR UI will render the docs.

Workaround bazelbuild/bazel-skylib#568

Allows us to guarantee stardoc can run across the graph.

Also:
publish a docs.tar.gz file on releases, so BCR UI will render the docs.
@alexeagle alexeagle requested a review from thesayyn September 29, 2025 16:10
@aspect-workflows
Copy link

aspect-workflows bot commented Sep 29, 2025

Test

All tests were cache hits

49 tests (100.0%) were fully cached saving 41s.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Comment on lines 1 to 3
load("@aspect_bazel_lib//lib:utils.bzl", bazel_lib_utils = "utils")
load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
load("@bazel_lib//:bzl_library.bzl", "bzl_library")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Add bazel_lib to workspace dependencies

The change replaces all bzl_library loads with @bazel_lib//:bzl_library.bzl (see this file), yet rules_oci_dependencies()—which non‑bzlmod users are instructed to call from WORKSPACE—still only declares bazel_skylib and never creates a bazel_lib repository. Any workspace integration will now fail with no such package '@bazel_lib//...'. An http_archive for bazel_lib should be added alongside the existing dependencies to keep legacy setups working.

Useful? React with 👍 / 👎.

alexeagle and others added 2 commits September 29, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant