Skip to content

feat: Allow configuration of tarball name #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peakschris wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: Allow configuration of tarball name #850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1961657
allow configuration of tarball name
peakschris Oct 15, 2025
e326a23
allow configuration of tarball name
peakschris Oct 16, 2025
7654836
update docs
peakschris Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/load.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion oci/private/load.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,10 @@ attrs = {
executable = True,
cfg = "target",
),
"tarball_name": attr.string(
Copy link
Collaborator

@thesayyn thesayyn Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we usually call this output using attr.output can you follow that pattern?

default = "tarball.tar",
doc = "Name of the tarball file to generate.",
),
"_run_template": attr.label(
default = Label("//oci/private:load.sh.tpl"),
doc = """ \
Expand Down Expand Up @@ -199,7 +203,7 @@ def _load_impl(ctx):

# This action produces a large output and should rarely be used as it puts load on the cache.
# It will only run if the "tarball" output_group is explicitly requested
tarball = ctx.actions.declare_file("{}/tarball.tar".format(ctx.label.name))
tarball = ctx.actions.declare_file("{}/{}".format(ctx.label.name, ctx.attr.tarball_name))
tar_inputs = depset(direct = mtree_outputs, transitive = [mtree_inputs])
tar_args = ctx.actions.args()
tar_args.add_all(["--create", "--no-xattr", "--no-mac-metadata"])
Expand Down