Skip to content

Commit 91a96dc

Browse files
committed
refactor: reduce the API surface of _create_whl_repos
1 parent a9cf358 commit 91a96dc

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

examples/bzlmod/MODULE.bazel.lock

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

python/private/pypi/extension.bzl

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@ def _create_whl_repos(
8080

8181
logger = repo_utils.logger(module_ctx, "pypi:create_whl_repos")
8282
python_interpreter_target = pip_attr.python_interpreter_target
83-
is_hub_reproducible = True
8483

8584
# if we do not have the python_interpreter set in the attributes
8685
# we programmatically find it.
@@ -221,7 +220,6 @@ def _create_whl_repos(
221220

222221
for distribution in dists:
223222
found_something = True
224-
is_hub_reproducible = False
225223

226224
if pip_attr.netrc:
227225
whl_library_args["netrc"] = pip_attr.netrc
@@ -310,7 +308,6 @@ def _create_whl_repos(
310308

311309
return struct(
312310
exposed_packages = exposed_packages,
313-
is_hub_reproducible = is_hub_reproducible,
314311
whl_libraries = whl_libraries,
315312
whl_map = whl_map,
316313
)
@@ -507,7 +504,7 @@ You cannot use both the additive_build_content and additive_build_content_file a
507504
# using an alternative cycle resolution strategy.
508505
hub_group_map[hub_name] = pip_attr.experimental_requirement_cycles
509506
exposed_packages.setdefault(hub_name, {}).update(result.exposed_packages)
510-
is_reproducible = is_reproducible and result.is_hub_reproducible
507+
is_reproducible = is_reproducible and get_index_urls == None
511508

512509
return struct(
513510
whl_mods = whl_mods,

0 commit comments

Comments
 (0)