Skip to content

Commit b302243

Browse files
committed
remove the configure attr
1 parent 3d4b697 commit b302243

File tree

1 file changed

+5
-14
lines changed

1 file changed

+5
-14
lines changed

python/private/pypi/extension.bzl

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -440,7 +440,6 @@ def parse_modules(
440440

441441
for tag in mod.tags.default:
442442
_configure(
443-
# TODO @aignas 2025-05-18: actually use all of this stuff
444443
defaults,
445444
arch_name = tag.arch_name,
446445
constraint_values = tag.constraint_values,
@@ -776,11 +775,11 @@ platform to be matched during analysis phase.
776775
"whls_limit": attr.int(default = -1),
777776
}
778777

779-
_configure_attrs = _default_attrs | {
780-
"hub_name": attr.string(),
781-
"python_version": attr.string(),
782-
"requirements_txt": attr.label(),
783-
}
778+
# _configure_attrs = _default_attrs | {
779+
# "hub_name": attr.string(),
780+
# "python_version": attr.string(),
781+
# "requirements_txt": attr.label(),
782+
# }
784783

785784
def _pip_parse_ext_attrs(**kwargs):
786785
"""Get the attributes for the pip extension.
@@ -1038,14 +1037,6 @@ the BUILD files for wheels.
10381037
""",
10391038
implementation = _pip_impl,
10401039
tag_classes = {
1041-
"configure": tag_class(
1042-
attrs = _configure_attrs,
1043-
doc = """\
1044-
This tag class allows for more customization of how the configuration for the hub repositories is built.
1045-
1046-
This is still experimental and may be changed or removed without any notice.
1047-
""",
1048-
),
10491040
"default": tag_class(
10501041
attrs = _default_attrs,
10511042
doc = """\

0 commit comments

Comments
 (0)