Skip to content

Conversation

rickeylev
Copy link
Collaborator

This allow the exec_interpreter attribute to propagate None even though it's a label
with a default value. Such attributes can't directly be set to None because None
means to use the default. To work around that, a sentinel target is used, which allows
breaking the dependency on the default and triggering the rule to use None instead.

A null exec interpreter is necessary in environments that don't provide a separate Python
interpreter.

@rickeylev rickeylev requested a review from oprypin September 6, 2024 07:25
@rickeylev rickeylev requested a review from aignas as a code owner September 6, 2024 07:25
@rickeylev rickeylev enabled auto-merge September 6, 2024 19:43
@oprypin oprypin disabled auto-merge September 6, 2024 20:27
@rickeylev rickeylev added this pull request to the merge queue Sep 6, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 6, 2024
@rickeylev rickeylev added this pull request to the merge queue Sep 6, 2024
Merged via the queue into bazel-contrib:main with commit f4596fb Sep 6, 2024
4 checks passed
@rickeylev rickeylev deleted the fix.optiona.exec.interpreter branch September 6, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants