feat: default py_runtime version info to --python_version
#2198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickeylev
force-pushed
the
feat.default.runtime.version.to.pyver.flag
branch
from
2313a77 to
484d38b
Compare
aignas
approved these changes
Sep 7, 2024
…o feat.default.runtime.version.to.pyver.flag
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes
py_runtimeto get its interpreter version from the--python_versionflag ifit wasn't explicitly specified. This is useful in two contexts:
For the runtime env toolchains, a local toolchain, or platform interpreter (basically any
py_runtime without a known version), it allows getting some Python version into the
analysis phase, which allows e.g. precompiling.
For environments using embedded Python, it allows defining fewer (e.g. 1)
py_runtimetarget instead of one for every Python version. This is because
py_runtimeserves a minorrole in such builds.