fix(platforms): include flag_values in config_settings #2236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function that allows us to generate config settings for supported platforms did not get the flag_values addition.
aignas
force-pushed
the
fix/platforms-contsraints
branch
from
6ee29c0 to
28594c2
Compare
rickeylev
approved these changes
Sep 21, 2024
|
I don't think it is used (apart from example/wheels tests), but the symbol is public. I would love to move the symbol to a non-public location, but I am not sure if that ship has not sailed yet.
…On 22 September 2024 01:51:05 GMT+09:00, Richard Levasseur ***@***.***> wrote:
@rickeylev approved this pull request.
Remind me -- what is gen_python_config_settings() used for? The only usage I see is in the toolchain_aliases.
--
Reply to this email directly or view it on GitHub:
#2236 (review)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function that allows us to generate config settings for
supported platforms did not get the flag_values addition.