Skip to content

chore: don't add migration tag if Starlark implementation is enabled #2257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 26, 2024
Merged

chore: don't add migration tag if Starlark implementation is enabled #2257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion python/private/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,10 @@ bzl_library(
visibility = [
"//:__subpackages__",
],
deps = ["@bazel_skylib//lib:types"],
deps = [
"@bazel_skylib//lib:types",
"@rules_python_internal//:rules_python_config_bzl",
],
)

bzl_library(
Expand Down
4 changes: 3 additions & 1 deletion python/private/util.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"""Functionality shared by multiple pieces of code."""

load("@bazel_skylib//lib:types.bzl", "types")
load("@rules_python_internal//:rules_python_config.bzl", "config")

def copy_propagating_kwargs(from_kwargs, into_kwargs = None):
"""Copies args that must be compatible between two targets with a dependency relationship.
Expand Down Expand Up @@ -60,7 +61,8 @@ def add_migration_tag(attrs):
Returns:
The same `attrs` object, but modified.
"""
add_tag(attrs, _MIGRATION_TAG)
if not config.enable_pystar:
add_tag(attrs, _MIGRATION_TAG)
return attrs

def add_tag(attrs, tag):
Expand Down