fix: fix errors with bazel@head #2332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so that the test works with Bazel@head
aignas
approved these changes
Oct 22, 2024
|
Although, looking at the CI it seems that it is still unhappy. |
rickeylev
changed the title
|
Heh, yeah, that required a few more fixes. All the integration tests needed rules_cc added, which then needed protobuf added. Then some allow_empty=True fixes in the local toolchain test. |
aignas
reviewed
Oct 23, 2024
Comment on lines
+3
to
+15
| http_archive( | ||
| name = "protobuf", | ||
| sha256 = "da288bf1daa6c04d03a9051781caa52aceb9163586bff9aa6cfb12f69b9395aa", | ||
| strip_prefix = "protobuf-27.0", | ||
| url = "https://github.com/protocolbuffers/protobuf/releases/download/v27.0/protobuf-27.0.tar.gz", | ||
| ) | ||
|
|
||
| http_archive( | ||
| name = "rules_cc", | ||
| sha256 = "d9bdd3ec66b6871456ec9c965809f43a0901e692d754885e89293807762d3d80", | ||
| strip_prefix = "rules_cc-0.0.13", | ||
| urls = ["https://github.com/bazelbuild/rules_cc/releases/download/0.0.13/rules_cc-0.0.13.tar.gz"], | ||
| ) |
There was a problem hiding this comment.
@rickeylev, I think this means that the py_repositories function adding these deps needs to be updated. This looks like the wrong thing to do if we want to keep supporting bazel@HEAD with a released rules_python version?
There was a problem hiding this comment.
Good point. Something felt off updating so many workspace files for tests. I've started #2335 to update py_repositories.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix various errors with upcoming Bazel versions
allow_empty=Truein local toolchains setupFixes #2310