fix(bzlmod): generate config_setting values for all python toolchains #2350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that default toolchain versions are the same as in the TOOL_VERSIONS array.
…ble versions I think that bazel-contrib#2253 has introduced an issue that went unnoticed because we did not have an integration test checking this. The main issue is that config settings of `is_python_3.x.y` were being generated only for registered toolchains and that is not necessarily the desired behaviour -- we may want to use the config settings for more values, so coupling that was a mistake.
rickeylev
approved these changes
Oct 26, 2024
aignas
added a commit
that referenced
this pull request
Oct 27, 2024
…#2350) PR #2253 broke how the config settings are generated and only generated the config setting values for the python version values that we would have the registered toolchains for. This PR restores the previous behaviour. However, if the root module uses `python.override` to remove the allowed toolchains, then `config_settings` will be also affected. (cherry picked from commit 9340a81) Conflicts: - CHANGELOG.md
aignas
added a commit
that referenced
this pull request
Oct 27, 2024
…#2350) PR #2253 broke how the config settings are generated and only generated the config setting values for the python version values that we would have the registered toolchains for. This PR restores the previous behaviour. However, if the root module uses `python.override` to remove the allowed toolchains, then `config_settings` will be also affected. (cherry picked from commit 9340a81) Conflicts: - CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2253 broke how the config settings are generated and only generated the config
setting values for the python version values that we would have the registered
toolchains for. This PR restores the previous behaviour. However, if the root
module uses
python.overrideto remove the allowed toolchains, thenconfig_settingswill be also affected.