Skip to content

fix: breakages in unused codepaths after recent refactors #2353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2024
Merged

fix: breakages in unused codepaths after recent refactors #2353

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/private/py_executable.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,7 +454,7 @@ def _get_base_runfiles_for_binary(
common_runfiles.files.add(implicit_pyc_source_files)

for dep in (ctx.attr.deps + extra_deps):
if not (PyInfo in dep or BuiltinPyInfo in dep):
if not (PyInfo in dep or (BuiltinPyInfo != None and BuiltinPyInfo in dep)):
continue
info = dep[PyInfo] if PyInfo in dep else dep[BuiltinPyInfo]
common_runfiles.files.add(info.transitive_sources)
Expand All @@ -471,7 +471,7 @@ def _get_base_runfiles_for_binary(

common_runfiles.runfiles.append(collect_runfiles(ctx))
if extra_deps:
common_runfiles.add_runfiles(targets = extra_deps)
common_runfiles.add_targets(extra_deps)
common_runfiles.add(extra_common_runfiles)

common_runfiles = common_runfiles.build(ctx)
Expand Down