Skip to content

fix: upgrade to rules_proto 7.0.2 to pickup fix for Bazel 9 #2408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 14, 2024
Merged

fix: upgrade to rules_proto 7.0.2 to pickup fix for Bazel 9 #2408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b57ac85
raise protobuf dep for workspace
rickeylev Nov 11, 2024
b5bef72
disable bazel_rolling test, go back to protobuf 27 for workspace
rickeylev Nov 11, 2024
ddfb3af
Upgrade rules_cc in WORKSPACE
comius Oct 11, 2024
3b5d8fa
Add protobuf dependency
comius Oct 11, 2024
c500a69
fixup! Merge remote-tracking branch 'upstream/main' into remove-cc-defs
rickeylev Oct 20, 2024
2722e29
try to use protobuf 29 in workspace for bazel 9
rickeylev Nov 12, 2024
5c0ceb4
add protobuf dep to py_repositories
rickeylev Nov 14, 2024
e391fca
go back ot proto 27 for workspace
rickeylev Nov 14, 2024
13f121e
undo other workspace changes
rickeylev Nov 14, 2024
58d6867
fully remove other workspace changes
rickeylev Nov 14, 2024
e0c433a
update bzlmod lockfile
rickeylev Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ bazel_dep(name = "rules_cc", version = "0.0.14")
bazel_dep(name = "platforms", version = "0.0.4")

# Those are loaded only when using py_proto_library
bazel_dep(name = "rules_proto", version = "6.0.2")
bazel_dep(name = "rules_proto", version = "7.0.2")
bazel_dep(name = "protobuf", version = "29.0-rc2", repo_name = "com_google_protobuf")

internal_deps = use_extension("//python/private:internal_deps.bzl", "internal_deps")
Expand Down
7 changes: 5 additions & 2 deletions examples/bzlmod/MODULE.bazel.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.