fix: normalize argv0 so runfiles root can be found on windows with bazel 9 #2481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aignas
approved these changes
Dec 7, 2024
Collaborator
|
Do we need to have |
Collaborator
Author
|
I'm ok with omitting a changelog entry for it. It's for an unreleased version of bazel (which I'm not sure can be used with rules_python right now), and the bug report didn't come from a user, so I doubt anybody has actually encountered it. |
ewianda
pushed a commit
to ewianda/rules_python
that referenced
this pull request
Dec 7, 2024
…zel 9 (bazel-contrib#2481) When the shell test invokes the python binary, it uses a combination of forward slashes and backslashes. Under Bazel 9, that mixture of slashes is preserved. This later breaks a regex that looks for the OS-specific path separator. To fix, normalize forward slashes to the OS path separator. Oddly, it's not Bazel that is passing the mixture of slashes (it's the shell), but behavior seems to vary based on which version of Bazel is used. Along the way, copy the nicer `print_verbose` function from the stage2 bootstrap into the old bootstrap. It prints debug information in a nicer format. Work towards bazel-contrib#2469
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the shell test invokes the python binary, it uses a combination of forward slashes and
backslashes. Under Bazel 9, that mixture of slashes is preserved. This later breaks a regex
that looks for the OS-specific path separator.
To fix, normalize forward slashes to the OS path separator.
Oddly, it's not Bazel that is passing the mixture of slashes (it's the shell), but behavior seems to
vary based on which version of Bazel is used.
Along the way, copy the nicer
print_verbosefunction from the stage2 bootstrap into the oldbootstrap. It prints debug information in a nicer format.
Work towards #2469