Skip to content

fix: define rules_python_internal earlier so Bazel 9 doesn't try to use PyInfo et al builtins #2485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 9, 2024
Merged

fix: define rules_python_internal earlier so Bazel 9 doesn't try to use PyInfo et al builtins #2485

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4191ac
fix: make Bazel 9 workspace builds recognize rules_python as the main…
rickeylev Dec 7, 2024
9e9d01c
Merge branch 'main' of https://github.com/bazelbuild/rules_python int…
rickeylev Dec 9, 2024
20baca9
fixup! Merge branch 'main' of https://github.com/bazelbuild/rules_pyt…
rickeylev Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions internal_dev_deps.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

load("@bazel_tools//tools/build_defs/repo:http.bzl", _http_archive = "http_archive", _http_file = "http_file")
load("@bazel_tools//tools/build_defs/repo:utils.bzl", "maybe")
load("//python/private:internal_config_repo.bzl", "internal_config_repo") # buildifier: disable=bzl-visibility

def http_archive(name, **kwargs):
maybe(
Expand All @@ -39,6 +40,7 @@ def rules_python_internal_deps():
For dependencies needed by *users* of rules_python, see
python/private/py_repositories.bzl.
"""
internal_config_repo(name = "rules_python_internal")

http_archive(
name = "bazel_skylib",
Expand Down
2 changes: 0 additions & 2 deletions internal_dev_setup.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,12 @@ load("@rules_proto//proto:repositories.bzl", "rules_proto_dependencies", "rules_
load("@rules_shell//shell:repositories.bzl", "rules_shell_dependencies", "rules_shell_toolchains")
load("//:version.bzl", "SUPPORTED_BAZEL_VERSIONS")
load("//python:versions.bzl", "MINOR_MAPPING", "TOOL_VERSIONS")
load("//python/private:internal_config_repo.bzl", "internal_config_repo") # buildifier: disable=bzl-visibility
load("//python/private:pythons_hub.bzl", "hub_repo") # buildifier: disable=bzl-visibility
load("//python/private/pypi:deps.bzl", "pypi_deps") # buildifier: disable=bzl-visibility

def rules_python_internal_setup():
"""Setup for development and testing of rules_python itself."""

internal_config_repo(name = "rules_python_internal")
hub_repo(
name = "pythons_hub",
minor_mapping = MINOR_MAPPING,
Expand Down