-
-
Notifications
You must be signed in to change notification settings - Fork 636
chore: remove internal usage of deprecated py_binary ad py_test #2569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aignas
merged 18 commits into
bazel-contrib:main
from
aignas:remove-internal-usage-of-transitions
Jan 22, 2025
Merged
Changes from 11 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
1e9e76f
chore: remove the internal usages of the deprecated py_binary and py_…
aignas f14d91b
buildifier
aignas 66e8896
add a note
aignas b63e8a2
deprecation message centralization
aignas 8c89c7e
add more stuff
aignas 0a7e42f
add more stuff
aignas 61f1bba
buildifier
aignas 6a7d1d1
fixup
aignas a3ef421
doc: add docstring
aignas 27e909e
Merge branch 'main' into remove-internal-usage-of-transitions
aignas 38467c0
config: deprecation warning defaults to false
aignas 57037e9
improve doc of envvar
rickeylev 6bf4281
comment: inline the deprecation warnings env var
aignas df6f580
rework the symbol deprecation and add tests to ensure that we are sti…
aignas fa883cf
fixup! rework the symbol deprecation and add tests to ensure that we …
aignas ece6b68
fixup tests
aignas 1b835c3
reshuffle the loads to make the tests compatible with WORKSPACE
aignas 8803d2e
fix the rules_python name in the other place
aignas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,10 @@ | ||
load("@python_versions//3.11:defs.bzl", compile_pip_requirements_311 = "compile_pip_requirements") | ||
load("@rules_python//python:pip.bzl", "compile_pip_requirements") | ||
|
||
# NOTE: To update the requirements, you need to uncomment the rules_python | ||
# override in the MODULE.bazel. | ||
compile_pip_requirements_311( | ||
compile_pip_requirements( | ||
name = "requirements", | ||
src = "requirements.in", | ||
python_version = "3.11", | ||
requirements_txt = "requirements_lock_3_11.txt", | ||
) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,28 +1,29 @@ | ||
load("@python//3.10:defs.bzl", compile_pip_requirements_3_10 = "compile_pip_requirements") | ||
load("@python//3.11:defs.bzl", compile_pip_requirements_3_11 = "compile_pip_requirements") | ||
load("@python//3.8:defs.bzl", compile_pip_requirements_3_8 = "compile_pip_requirements") | ||
load("@python//3.9:defs.bzl", compile_pip_requirements_3_9 = "compile_pip_requirements") | ||
load("@rules_python//python:pip.bzl", "compile_pip_requirements") | ||
|
||
compile_pip_requirements_3_8( | ||
compile_pip_requirements( | ||
name = "requirements_3_8", | ||
src = "requirements.in", | ||
python_version = "3.8", | ||
requirements_txt = "requirements_lock_3_8.txt", | ||
) | ||
|
||
compile_pip_requirements_3_9( | ||
compile_pip_requirements( | ||
name = "requirements_3_9", | ||
src = "requirements.in", | ||
python_version = "3.9", | ||
requirements_txt = "requirements_lock_3_9.txt", | ||
) | ||
|
||
compile_pip_requirements_3_10( | ||
compile_pip_requirements( | ||
name = "requirements_3_10", | ||
src = "requirements.in", | ||
python_version = "3.10", | ||
requirements_txt = "requirements_lock_3_10.txt", | ||
) | ||
|
||
compile_pip_requirements_3_11( | ||
compile_pip_requirements( | ||
name = "requirements_3_11", | ||
src = "requirements.in", | ||
python_version = "3.11", | ||
requirements_txt = "requirements_lock_3_11.txt", | ||
) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.