Skip to content

feat(python.toolchain): support file-based default Python version #2588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 29, 2025
Merged

feat(python.toolchain): support file-based default Python version #2588

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6813055
feat(python.toolchain): support file-based default Python version
vonschultz Jan 28, 2025
e0b7a3d
Update python/private/python.bzl
aignas Mar 7, 2025
f2cc08a
Update python/private/python.bzl
aignas Mar 7, 2025
31cb09c
Update python/private/python.bzl
aignas Mar 7, 2025
86d17aa
doc: add changelog
aignas Mar 7, 2025
0228b9d
Merge branch 'main' into default_version_file
aignas Mar 7, 2025
2b1286d
adjust changelog
aignas Mar 7, 2025
f4631dc
Merge branch 'bazel-contrib:main' into default_version_file
vonschultz Mar 18, 2025
4acb4d7
feat: Implement a python.defaults tag class
vonschultz Mar 18, 2025
678a608
Use Label when resolving @@//:.python-version
vonschultz Mar 21, 2025
b5a337b
Drop support for Bazel 7.0 in python_version_env
vonschultz Mar 21, 2025
1a94ad4
Explicitly watch the python version file we read
vonschultz Mar 21, 2025
5bdfbe2
Stop attempting to read @@//:.python-version
vonschultz Mar 28, 2025
c601c06
Merge branch 'main' into default_version_file
aignas Mar 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions examples/multi_python_versions/MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,8 @@ python.defaults(
)
python.toolchain(
configure_coverage_tool = True,
python_version = "3.8",
)
python.toolchain(
configure_coverage_tool = True,
# Only set when you have mulitple toolchain versions.
is_default = True,
Copy link
Contributor Author

@vonschultz vonschultz May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding back is_default = True, in the merge commit wasn't the intention, was it? When we're using python.defaults, we shouldn't also use is_default = True.

Copy link
Collaborator

@aignas aignas May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably messed up the merge conflict handling.

Copy link
Contributor Author

@vonschultz vonschultz May 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix in #2924, which also moves other examples and docs over to python.defaults.

python_version = "3.9",
)
python.toolchain(
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.