Skip to content

fix(coverage): prevent issues when packages execute files in tmp dir. #2599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

fix(coverage): prevent issues when packages execute files in tmp dir. #2599

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07fe22d
fix(coverage): prevent issues when packages execute files in tmp dir.
BurnzZ Feb 2, 2025
91d6cbe
Use tempfile module to instead of $TMPDIR
BurnzZ Feb 3, 2025
312d9ad
add link leading to coveragepy reporting issue
BurnzZ Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ Unreleased changes template.
The related issue is [#908](https://github.com/bazelbuild/rules_python/issue/908).
* (sphinxdocs) Do not crash when `tag_class` does not have a populated `doc` value.
Fixes ([#2579](https://github.com/bazelbuild/rules_python/issues/2579)).
* (coverage) Prevent coveragepy report issues when packages execute files in tmp dir.
Fixes ([#2575](https://github.com/bazelbuild/rules_python/issues/2575)).

{#v0-0-0-added}
### Added
Expand Down
3 changes: 3 additions & 0 deletions python/private/python_bootstrap_template.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -461,6 +461,9 @@ relative_files = True
kparams['stdout'] = sys.stderr
kparams['stderr'] = sys.stderr

# Prevent coveragepy report issues when packages execute files in tmp dir.
params.append('--omit="$TMPDIR/*"')

ret_code = subprocess.call(
params,
**kparams
Expand Down