Skip to content

refactor: cleanup now-unreferenced proto toolchain type #2620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 22, 2025
Merged

refactor: cleanup now-unreferenced proto toolchain type #2620

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e95f95f
chore: cleanup now-unreferenced proto toolchain type
alexeagle Feb 20, 2025
04ade9a
add deprecation
alexeagle Feb 21, 2025
5d20c4a
Update BUILD.bazel
alexeagle Feb 21, 2025
d1d3b3b
add deprecation attr to alias
rickeylev Feb 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions python/proto/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,11 @@

package(default_visibility = ["//visibility:public"])

# Toolchain type provided by proto_lang_toolchain rule and used by py_proto_library
toolchain_type(name = "toolchain_type")
# Deprecated; use @com_google_protobuf//bazel/private:python_toolchain_type instead.
# Alias is here to provide backward-compatibility; see #2604
# It will be removed in a future release.
alias(
name = "toolchain_type",
actual = "@com_google_protobuf//bazel/private:python_toolchain_type",
deprecation = "Use @com_google_protobuf//bazel/private:python_toolchain_type instead",
)
Loading