Skip to content

Add error for pip.parse attrs that require other attrs #2646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2025
Merged

Add error for pip.parse attrs that require other attrs #2646

merged 1 commit into from
Mar 3, 2025

Conversation

@keith
Copy link
Member

@keith keith commented Mar 3, 2025

This makes it more clear when you've misconfigured pip.parse

@keith
Add error for pip.parse attrs that require other attrs
7d785f9 
This makes it more clear when you've misconfigured pip.parse
aignas
aignas approved these changes Mar 3, 2025
View reviewed changes
Copy link
Collaborator

@aignas aignas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aignas aignas added this pull request to the merge queue Mar 3, 2025
Merged via the queue into bazel-contrib:main with commit 1226caa Mar 3, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aignas aignas aignas approved these changes

@rickeylev rickeylev Awaiting requested review from rickeylev rickeylev is a code owner

@groodt groodt Awaiting requested review from groodt groodt is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@keith @aignas