Skip to content

fix: Prevent absolute path creation in uv lock template #2769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 11, 2025
Merged

fix: Prevent absolute path creation in uv lock template #2769

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b51cbb7
Fix case where lock is at the root of a workspace
asa Apr 10, 2025
441fc47
revert python version
asa Apr 10, 2025
cecff3c
Merge branch 'main' into asa_lock_in_root_package
asa Apr 10, 2025
223cad9
Update python/uv/private/lock.bzl
aignas Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion python/uv/private/lock.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,10 +327,15 @@ def _maybe_file(path):
def _expand_template_impl(ctx):
pkg = ctx.label.package
update_src = ctx.actions.declare_file(ctx.attr.update_target + ".py")

# Fix the path construction to avoid absolute paths
# If package is empty (root), don't add a leading slash
dst = ctx.attr.output if pkg == "" else "{}/{}".format(pkg, ctx.attr.output)

ctx.actions.expand_template(
template = ctx.files._template[0],
substitutions = {
"{{dst}}": "{}/{}".format(pkg, ctx.attr.output),
"{{dst}}": dst,
"{{src}}": "{}".format(ctx.files.src[0].short_path),
"{{update_target}}": "//{}:{}".format(pkg, ctx.attr.update_target),
},
Expand Down