Skip to content

fix: replace string with modern providers in tests #2773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025
Merged

fix: replace string with modern providers in tests #2773

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba17a42
Replace string with modern providers in tests
comius Apr 14, 2025
74b8901
Add docs
comius Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions tests/builders/attr_builders_tests.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ def _expect_cfg_defaults(expect, cfg):
expect.where(expr = "cfg.which_cfg").that_str(cfg.which_cfg()).equals("target")

_some_aspect = aspect(implementation = lambda target, ctx: None)
_SomeInfo = provider("MyInfo", fields = [])

_tests = []

Expand Down Expand Up @@ -186,7 +187,7 @@ def _test_label(name):
subject.set_executable(True)
subject.add_allow_files(".txt")
subject.cfg.set_target()
subject.providers().append("provider")
subject.providers().append(_SomeInfo)
subject.aspects().append(_some_aspect)
subject.cfg.outputs().append(Label("//some:output"))
subject.cfg.inputs().append(Label("//some:input"))
Expand All @@ -199,7 +200,7 @@ def _test_label(name):
expect.that_bool(subject.executable()).equals(True)
expect.that_collection(subject.allow_files()).contains_exactly([".txt"])
expect.that_bool(subject.allow_single_file()).equals(None)
expect.that_collection(subject.providers()).contains_exactly(["provider"])
expect.that_collection(subject.providers()).contains_exactly([_SomeInfo])
expect.that_collection(subject.aspects()).contains_exactly([_some_aspect])
expect.that_collection(subject.cfg.outputs()).contains_exactly([Label("//some:output")])
expect.that_collection(subject.cfg.inputs()).contains_exactly([Label("//some:input")])
Expand Down Expand Up @@ -229,7 +230,7 @@ def _test_label_keyed_string_dict(name):
subject.set_mandatory(True)
subject.set_allow_files(True)
subject.cfg.set_target()
subject.providers().append("provider")
subject.providers().append(_SomeInfo)
subject.aspects().append(_some_aspect)
subject.cfg.outputs().append("//some:output")
subject.cfg.inputs().append("//some:input")
Expand All @@ -240,7 +241,7 @@ def _test_label_keyed_string_dict(name):
expect.that_str(subject.doc()).equals("doc")
expect.that_bool(subject.mandatory()).equals(True)
expect.that_bool(subject.allow_files()).equals(True)
expect.that_collection(subject.providers()).contains_exactly(["provider"])
expect.that_collection(subject.providers()).contains_exactly([_SomeInfo])
expect.that_collection(subject.aspects()).contains_exactly([_some_aspect])
expect.that_collection(subject.cfg.outputs()).contains_exactly(["//some:output"])
expect.that_collection(subject.cfg.inputs()).contains_exactly(["//some:input"])
Expand Down Expand Up @@ -274,14 +275,14 @@ def _test_label_list(name):
subject.set_doc("doc")
subject.set_mandatory(True)
subject.set_allow_files([".txt"])
subject.providers().append("provider")
subject.providers().append(_SomeInfo)
subject.aspects().append(_some_aspect)

expect.that_collection(subject.default()).contains_exactly(["//some:label"])
expect.that_str(subject.doc()).equals("doc")
expect.that_bool(subject.mandatory()).equals(True)
expect.that_collection(subject.allow_files()).contains_exactly([".txt"])
expect.that_collection(subject.providers()).contains_exactly(["provider"])
expect.that_collection(subject.providers()).contains_exactly([_SomeInfo])
expect.that_collection(subject.aspects()).contains_exactly([_some_aspect])

_expect_builds(expect, subject, "attr.label_list")
Expand Down Expand Up @@ -395,14 +396,14 @@ def _test_string_keyed_label_dict(name):
subject.set_doc("doc")
subject.set_mandatory(True)
subject.set_allow_files([".txt"])
subject.providers().append("provider")
subject.providers().append(_SomeInfo)
subject.aspects().append(_some_aspect)

expect.that_dict(subject.default()).contains_exactly({"key": "//some:label"})
expect.that_str(subject.doc()).equals("doc")
expect.that_bool(subject.mandatory()).equals(True)
expect.that_collection(subject.allow_files()).contains_exactly([".txt"])
expect.that_collection(subject.providers()).contains_exactly(["provider"])
expect.that_collection(subject.providers()).contains_exactly([_SomeInfo])
expect.that_collection(subject.aspects()).contains_exactly([_some_aspect])

_expect_builds(expect, subject, "attr.string_keyed_label_dict")
Expand Down