Skip to content

fix: add target platform to extra exec platforms in analysis tests #2861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2025
Merged

fix: add target platform to extra exec platforms in analysis tests #2861

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07e8bc9
fix: add target platform to extra exec platforms in analysis tests
fmeum May 5, 2025
e5908dc
Fix buildifier lint
fmeum May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tests/base_rules/py_executable_base_tests.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ def _test_basic_windows(name, config):
"//command_line_option:crosstool_top": CROSSTOOL_TOP,
"//command_line_option:extra_toolchains": [CC_TOOLCHAIN],
"//command_line_option:platforms": [WINDOWS_X86_64],
"//command_line_option:extra_execution_platforms": [WINDOWS_X86_64],
},
attr_values = {"target_compatible_with": target_compatible_with},
)
Expand Down Expand Up @@ -98,6 +99,7 @@ def _test_basic_zip(name, config):
"//command_line_option:crosstool_top": CROSSTOOL_TOP,
"//command_line_option:extra_toolchains": [CC_TOOLCHAIN],
"//command_line_option:platforms": [LINUX_X86_64],
"//command_line_option:extra_execution_platforms": [LINUX_X86_64],
},
attr_values = {"target_compatible_with": target_compatible_with},
)
Expand Down
2 changes: 2 additions & 0 deletions tests/base_rules/py_test/py_test_tests.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ def _test_mac_requires_darwin_for_execution(name, config):
"//command_line_option:crosstool_top": CROSSTOOL_TOP,
"//command_line_option:extra_toolchains": CC_TOOLCHAIN,
"//command_line_option:platforms": [MAC_X86_64],
"//command_line_option:extra_execution_platforms": [MAC_X86_64],
},
attr_values = _SKIP_WINDOWS,
)
Expand Down Expand Up @@ -94,6 +95,7 @@ def _test_non_mac_doesnt_require_darwin_for_execution(name, config):
"//command_line_option:crosstool_top": CROSSTOOL_TOP,
"//command_line_option:extra_toolchains": CC_TOOLCHAIN,
"//command_line_option:platforms": [LINUX_X86_64],
"//command_line_option:extra_execution_platforms": [LINUX_X86_64],
},
attr_values = _SKIP_WINDOWS,
)
Expand Down