Skip to content

refactor: Add missing uses of DefaultInfo #2972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025
Merged

refactor: Add missing uses of DefaultInfo #2972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions python/private/common.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,7 @@ def create_py_info(
else:
# TODO(b/228692666): Remove this once non-PyInfo targets are no
# longer supported in `deps`.
files = target.files.to_list()
files = target[DefaultInfo].files.to_list()
for f in files:
if f.extension == "py":
py_info.transitive_sources.add(f)
Expand All @@ -449,7 +449,7 @@ def create_py_info(
info = _get_py_info(target)
py_info.merge_uses_shared_libraries(info.uses_shared_libraries)
else:
files = target.files.to_list()
files = target[DefaultInfo].files.to_list()
for f in files:
py_info.merge_uses_shared_libraries(cc_helper.is_valid_shared_library_artifact(f))
if py_info.get_uses_shared_libraries():
Expand Down
4 changes: 2 additions & 2 deletions python/private/py_wheel.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,7 +480,7 @@ def _py_wheel_impl(ctx):
args.add("--no_compress")

for target, filename in ctx.attr.extra_distinfo_files.items():
target_files = target.files.to_list()
target_files = target[DefaultInfo].files.to_list()
if len(target_files) != 1:
fail(
"Multi-file target listed in extra_distinfo_files %s",
Expand All @@ -493,7 +493,7 @@ def _py_wheel_impl(ctx):
)

for target, filename in ctx.attr.data_files.items():
target_files = target.files.to_list()
target_files = target[DefaultInfo].files.to_list()
if len(target_files) != 1:
fail(
"Multi-file target listed in data_files %s",
Expand Down
2 changes: 1 addition & 1 deletion python/uv/private/uv_toolchain.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ def _uv_toolchain_impl(ctx):
uv = ctx.attr.uv

default_info = DefaultInfo(
files = uv.files,
files = uv[DefaultInfo].files,
runfiles = uv[DefaultInfo].default_runfiles,
)
uv_toolchain_info = UvToolchainInfo(
Expand Down
2 changes: 1 addition & 1 deletion sphinxdocs/private/sphinx.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,7 @@ def _sphinx_source_tree_impl(ctx):
_relocate(orig_file)

for src_target, dest in ctx.attr.renamed_srcs.items():
src_files = src_target.files.to_list()
src_files = src_target[DefaultInfo].files.to_list()
if len(src_files) != 1:
fail("A single file must be specified to be renamed. Target {} " +
"generate {} files: {}".format(
Expand Down