Skip to content

feat(pypi): generate filegroup with all extracted wheel files #3011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jul 7, 2025
Merged

feat(pypi): generate filegroup with all extracted wheel files #3011

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
ba62630
feat: generate filegroup with all extracted wheel files
rickeylev Jun 17, 2025
aac9bf7
feat(pypi): Add filegroup for all extracted wheel files
google-labs-jules[bot] Jun 20, 2025
a68c31e
Merge branch 'main' of https://github.com/bazel-contrib/rules_python …
rickeylev Jun 20, 2025
63af927
Merge and fix changelog
rickeylev Jun 20, 2025
80ac1f7
fix up filegroup arg
rickeylev Jun 20, 2025
ee51ad2
add version note
rickeylev Jun 20, 2025
021746b
remove defunct todo
rickeylev Jun 20, 2025
c2a377a
fix var typo
rickeylev Jun 20, 2025
bc99905
pass sdist filename along
rickeylev Jun 25, 2025
de1a3e0
Merge branch 'main' of https://github.com/bazel-contrib/rules_python …
rickeylev Jun 25, 2025
0674887
Merge branch 'feat.pypi.all.files' of https://github.com/rickeylev/ru…
rickeylev Jun 25, 2025
1f03a3f
exclude build file from all files target
rickeylev Jun 25, 2025
8b820e1
exclude more special bazel files
rickeylev Jun 25, 2025
79288e6
Merge branch 'main' of https://github.com/bazel-contrib/rules_python …
rickeylev Jul 7, 2025
11f41c5
fix tests
rickeylev Jul 7, 2025
5688f16
lint
rickeylev Jul 7, 2025
dc10d5b
Merge branch 'main' of https://github.com/bazel-contrib/rules_python …
rickeylev Jul 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions python/private/pypi/labels.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

"""Constants used by parts of pip_repository for naming libraries and wheels."""

EXTRACTED_WHEEL_FILES = "extracted_whl_files"
WHEEL_FILE_PUBLIC_LABEL = "whl"
WHEEL_FILE_IMPL_LABEL = "_whl"
PY_LIBRARY_PUBLIC_LABEL = "pkg"
Expand Down
18 changes: 14 additions & 4 deletions python/private/pypi/whl_library_targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ load(
":labels.bzl",
"DATA_LABEL",
"DIST_INFO_LABEL",
"EXTRACTED_WHEEL_FILES",
"PY_LIBRARY_IMPL_LABEL",
"PY_LIBRARY_PUBLIC_LABEL",
"WHEEL_ENTRY_POINT_PREFIX",
Expand Down Expand Up @@ -101,8 +102,16 @@ def whl_library_targets(
srcs_exclude = [],
tags = [],
filegroups = {
DIST_INFO_LABEL: ["site-packages/*.dist-info/**"],
DATA_LABEL: ["data/**"],
EXTRACTED_WHEEL_FILES: dict(
include = ["**"],
exclude = ["*.whl"],
),
DIST_INFO_LABEL: dict(
include = ["site-packages/*.dist-info/**"],
),
DATA_LABEL: dict(
include = ["data/**"],
),
},
dependencies = [],
dependencies_by_platform = {},
Expand Down Expand Up @@ -168,10 +177,11 @@ def whl_library_targets(
tags = sorted(tags)
data = [] + data

for filegroup_name, glob in filegroups.items():
for filegroup_name, glob_kwargs in filegroups.items():
glob_kwargs = {"allow_empty": True} | glob_kwargs
native.filegroup(
name = filegroup_name,
srcs = native.glob(glob, allow_empty = True),
srcs = native.glob(**glob_kwargs),
visibility = ["//visibility:public"],
)

Expand Down