fix(gazelle) Register pyi_deps as ResolveAttrs #3037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dougthor42
reviewed
Jun 28, 2025
and a case of deps being only partially removed.
dougthor42
approved these changes
Jun 30, 2025
Collaborator
dougthor42
left a comment
dougthor42
left a comment
There was a problem hiding this comment.
Thanks for the updated tests! Those look great.
amartani
added a commit
to benchling/rules_python
that referenced
this pull request
Jul 8, 2025
Fix an issue in bazel-contrib#3014 where, when all type-checking dependencies are removed from a file, the corresponding target's `pyi_deps` doesn't get cleaned up. I traced this back to `ResolveAttrs`, though I'm not entirely sure of what other behaviors this may trigger. (Currently, removing `deps` from `ResolveAttrs` doesn't break any existing test case) (No new changelog entry since this is a fix to an unreleased feature that is already in the changelog)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue in #3014 where, when all type-checking dependencies are removed from a file, the corresponding target's
pyi_depsdoesn't get cleaned up. I traced this back toResolveAttrs, though I'm not entirely sure of what other behaviors this may trigger. (Currently, removingdepsfromResolveAttrsdoesn't break any existing test case)(No new changelog entry since this is a fix to an unreleased feature that is already in the changelog)