Skip to content

Conversation

@fionera
Copy link
Contributor

@fionera fionera commented Jul 14, 2025

This allows system which don't have this location (looking at you NixOS) to run the scripts.

@fionera fionera requested review from aignas and rickeylev as code owners July 14, 2025 16:58
Copy link
Collaborator

@aignas aignas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also add a note to CHANGELOG? Something like:

(core) #!/usr/bin/env bash is now used as a shebang in the stage1 bootstrap template.

This allows system which don't have this location (looking at you NixOS) to run the scripts.
@fionera fionera force-pushed the replace-bin-bash branch from 5bb24f3 to b4c7269 Compare July 15, 2025 07:29
Copy link
Collaborator

@aignas aignas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aignas aignas added this pull request to the merge queue Jul 15, 2025
Merged via the queue into bazel-contrib:main with commit b89765c Jul 15, 2025
3 checks passed
@fionera fionera deleted the replace-bin-bash branch July 15, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants