Skip to content

fix: normalize stub_path in repl.bzl #3104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aignas merged 4 commits into from
Jul 22, 2025
Merged

fix: normalize stub_path in repl.bzl #3104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a37924a
fix #3101 - Normalize stub_path in repl.bzl
jpwoodbu Jul 17, 2025
7f642ea
Use Python's normpath()
jpwoodbu Jul 20, 2025
490d988
Merge branch 'main' into patch-1
jpwoodbu Jul 21, 2025
0e1faff
Update CHANGELOG.md
aignas Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,8 @@ END_UNRELEASED_TEMPLATE
([#3099](https://github.com/bazel-contrib/rules_python/issues/3099)).
* (pypi) Expose pypi packages only common to all Python versions in `all_requirements`
([#2921](https://github.com/bazel-contrib/rules_python/issues/2921)).
* (repl) Normalize the path for the `REPL` stub to make it possible to use the
default stub template from outside `rules_python` ({gh-issue}`3101`).

{#v0-0-0-added}
### Added
Expand Down
4 changes: 3 additions & 1 deletion python/private/repl_template.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@

from python.runfiles import runfiles

STUB_PATH = "%stub_path%"
# runfiles.py will reject paths which aren't normalized, which can happen when the REPL rules are
# used from a remote module.
STUB_PATH = os.path.normpath("%stub_path%")


def start_repl():
Expand Down