fix(pypi): expose pypi packages only common to all python versions #3107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aignas
reviewed
Jul 20, 2025
Collaborator
aignas
left a comment
aignas
left a comment
There was a problem hiding this comment.
Logic LGTM, but it would be also good to add a line in CHANGELOG in the Fixed section to ensure that users get informed about the change.
Co-authored-by: Ignas Anikevicius <[email protected]>
dotoleeoak
changed the title
Contributor
Author
|
It seems the current CI failures come from GitHub's partial outage |
aignas
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2921
For a single pypi repo with multiple python versions,
all_requirementsfail when a pypi package supports Python version A but not version B. In this case, the pypi package would be included only in requirements lock file for version A, not in one for version B. However, the failure occurs since the package is included inall_requirementseven for Python version B.(Minimal reproduction: https://github.com/dotoleeoak/rules-python-2921-repro)
This happens since
packagesparameter forhub_repositorytargets are including all packages across all requirement lock files. Instead of union of packages, intersection of packages for requirement files should be passed topackagesand exposed toall_requirementsmacro, so that those packages are compatible with all Python versions.