feat(repl): add tab completion on platforms with readline support #3114
Conversation
|
I think #3104 needs to merged into this so that the |
jpwoodbu
force-pushed
the
fix-repl-tab-completion
branch
from
6ee1b0f to
e3dbb91
Compare
jpwoodbu
force-pushed
the
fix-repl-tab-completion
branch
from
e3dbb91 to
991fbab
Compare
I believe I've gotten that merge done. I'm surprised by the CI failures. They make it look like the merge wasn't successful, but the content of the commit the tests used looks correct to me. |
I noticed that the CI error messages for bazel-contrib#3114 are not useful. This patch aims to help with that by printing the output of the REPL code. If there's an exception during startup for example, then the test log will now contain the stack trace.
I noticed that the CI error messages for #3114 are not useful. This patch aims to help with that by printing the output of the REPL code. If there's an exception during startup for example, then the test log will now contain the stack trace. --------- Co-authored-by: Ignas Anikevicius <[email protected]>
|
I'm seeing more clear error messages now. It seems the |
The readline module is not avialable on all platforms.
This commit also makes an attempt to minimize the amount of code within the `try` block for importing `realine`.
aignas
left a comment
aignas
left a comment
There was a problem hiding this comment.
LGTM, could you please add a CHANGELOG.md entry for this? This will be useful for the users to know!
Thanks! Done. |
aignas
changed the title
aignas
changed the title
2 participants
This adds tab completion to the default stub when using the REPL feature.
However, the feature only works in environments with
readlinesupport,which means that with the bundled toolchains, Windows will not have tab
completion.
Work towards #3090