Skip to content

test: Print REPL error message during test failures #3124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 1, 2025
Merged

test: Print REPL error message during test failures #3124

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1469452
fix: Print REPL error message during test failures
philsc Jul 28, 2025
928b79d
fix exception type
philsc Jul 28, 2025
10ca490
Merge branch 'main' into improve-repl-test-failure-messages
aignas Aug 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions tests/repl/repl_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,16 @@ def setUp(self):

def run_code_in_repl(self, lines: Iterable[str], *, env=None) -> str:
"""Runs the lines of code in the REPL and returns the text output."""
return subprocess.check_output(
[self.repl],
text=True,
stderr=subprocess.STDOUT,
input="\n".join(lines),
env=env,
).strip()
try:
return subprocess.check_output(
[self.repl],
text=True,
stderr=subprocess.STDOUT,
input="\n".join(lines),
env=env,
).strip()
except subprocess.CalledProcessError as error:
raise RuntimeError(f"Failed to run the REPL:\n{error.stdout}") from error

def test_repl_version(self):
"""Validates that we can successfully execute arbitrary code on the REPL."""
Expand Down