-
-
Notifications
You must be signed in to change notification settings - Fork 639
docs(toolchains): set dev_dependency=True on repo rule invocation #3127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Remove `dev_dependency = True` for use_repo_rule invocations - invalid kwarg
aignas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not what the bazel docs say here
|
Hmm, not what I'm seeing in our CI: https://github.com/protocolbuffers/protobuf/actions/runs/16726777050/job/47344412543#step:6:592 cc @rickeylev |
|
@meteorcloudy, could you please clarify if this is a bug in bazel or bazel docs? |
|
The I can see how the doc might be confusing, happy to help review a PR to help clarify this! /cc @Wyverald |
|
Thanks for fixing the docs @honglooker! |
|
np :) |
Move
dev_dependency = Trueto the repo rule invocation. Theuse_repo_rulecalldoesn't support that arg.