refactor(pypi): use a builder pattern for parsing requirements #3159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst trying to finish the configuration API I bumped into the issue that the API of the `parse_requirements` function does not lend itself to building the configuration easily. With this we will be able to build the configuration more easily and have more customization without passing ever more complex structures between the functions. What is more, I believe that it may be possible to have more complex composable builders in the future to build the `whl_library` args with a single `build` command instead of what we have now. Work towards bazel-contrib#2747
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst trying to finish the configuration API I bumped into the issue
that the API of the
parse_requirementsfunction does not lend itselfto building the configuration easily.
With this we will be able to build the configuration more easily and
have more customization without passing ever more complex structures
between the functions. What is more, I believe that it may be possible
to have more complex composable builders in the future to build the
whl_libraryargs with a singlebuildcommand instead of what we havenow.
Work towards #2747