Skip to content

Flip incompatible_strict_action_env in examples #3160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hofbi
Copy link
Contributor

@hofbi hofbi commented Aug 11, 2025

Reproduce what we found in bazelbuild/bazel#26587 (comment)

PR Instructions/requirements

  • Title uses type: description format. See CONTRIBUTING.md for types.
    • Common types are: build, docs, feat, fix, refactor, revert, test
    • Update CHANGELOG.md as applicable
  • Breaking changes include "!" after the type and a "BREAKING CHANGES:"
    section at the bottom.
    See CONTRIBUTING.md for our breaking changes process.
  • Body text describes:
    • Why this change is being made, briefly.
    • Before and after behavior, as applicable
    • References issue number, as applicable
  • Update docs and tests, as applicable
  • Delete these instructions prior to sending the PR

@hofbi hofbi force-pushed the flip-incompatible_strict_action_env branch from fd4e075 to 57d1645 Compare August 11, 2025 22:23
@hofbi
Copy link
Contributor Author

hofbi commented Aug 12, 2025

@rickeylev I am currently working on bazelbuild/bazel#26587 and @meteorcloudy helped me to trigger https://buildkite.com/bazel/bcr-bazel-compatibility-test/builds/492 to test the flip. We found an issue in the rules_python windows build here which should be in https://github.com/bazel-contrib/rules_python/tree/main/examples/multi_python_versions.

Now I am trying to reproduce this in this repo, but CI is still green. Am I setting the flag at the right spot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant