deps(gazelle): upgrade rules_go to remove patching of tree-sitter #3179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
force-pushed
the
stop-hacking-tree-sitter
branch
from
f8b94b9 to
63a642a
Compare
dougthor42
reviewed
Aug 15, 2025
There was a problem hiding this comment.
Odd... how did you avoid the windows issues with go-tree-sitter that I was seeing in #2962?
Ah well, I'm not going to look a gift horse in the mouth. This is awesome, thanks!
Requests:
- Update
CHANGELOG.mdto specify the version upgrades and thatloadstatements might get reordered. - Update
MODULE.bazel'srules_goversion to match what's used bygazelle/MODULE.bazel. - Update
internal_dev_deps.bzlto match too. - Update
examples/(bzlmod_)build_file_generationto match versions too.
dougthor42
changed the title
I have no idea, don't jinx it! 😅 |
jbedard
commented
Aug 15, 2025
jbedard
commented
Aug 15, 2025
jbedard
commented
Aug 15, 2025
jbedard
commented
Aug 15, 2025
|
Now after upgrading things there's some odd failures. @dougthor42 can you take a look? |
dougthor42
reviewed
Aug 15, 2025
There was a problem hiding this comment.
To summarize all the comments:
- You should be able to revert the
.bazelignoreand.bazelrcchanges.- Doing so tested just fine for me locally, so 🤞.
- You may be able to revert the change to root
MODULE.bazelandWORKSPACE- Sorry for requesting those initially!
- It seems like ae0f4be worked and just needs a CI retry.
- Some nits
jbedard
force-pushed
the
stop-hacking-tree-sitter
branch
2 times, most recently
from
ae0f4be to
353ec71
Compare
jbedard
force-pushed
the
stop-hacking-tree-sitter
branch
from
c4004be to
1ddc60b
Compare
This reverts commit 0f0ffe6.
dougthor42
reviewed
Aug 15, 2025
dougthor42
approved these changes
Aug 15, 2025
There was a problem hiding this comment.
I opened #3180 for the CI flake.
I'm just going to test it on our internal monorepo this morning to double check, but I don't expect any issues.
Things look good on my end. Approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update rules_go to include bazel-contrib/rules_go#4298
Update gazelle to align with the version the rules_go bzlmod will bring in, and ensure the go.mod version is the same as bzlmod version.
Update go to 1.21 to include the
sliceslibrary that some of the go.mod updates depend on.Fixes #2956.