backport: PR#3178 to 1.5 #3217
Merged
backport: PR#3178 to 1.5 #3217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lable. (#3178) Search directory for libraries should look in the same directory as sys._base_executable. Since sys._base_executable may be unset, fallback to sys.executable Found this when trying to build using a venv for [tensorstore](https://github.com/google/tensorstore) on Windows: * Github CI uses nuget to download Python. * Build sets up a Python venv. The venv does not include all the lib directories required to link an extension. Fixes #3172 --------- Co-authored-by: Richard Levasseur <[email protected]>
Contributor
Author
|
Whoa, this pulled in a lot more than I expected. Think I'll need to re-do this. |
Contributor
Author
|
Ah, was the wrong base. Updated |
rickeylev
approved these changes
Aug 28, 2025
Collaborator
|
CI failure is something that was fixed at head and just part of the CI config (old ubuntu version, iirc). Merging. |
This was referenced Aug 28, 2025
Closed
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 29, 2025
Update the main changelog with 1.5.4 notes from #3217
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(local_runtime): Search for libs in sys._base_executable when available. (#3178)
Search directory for libraries should look in the same directory as
sys._base_executable. Since sys._base_executable may be unset, fallback
to sys.executable
Found this when trying to build using a venv for
tensorstore on Windows:
* Github CI uses nuget to download Python.
* Build sets up a Python venv.
The venv does not include all the lib directories required to link an
extension.
Fixes #3172
Co-authored-by: Richard Levasseur [email protected]