fix(pypi): add __init__.py to site-packages directories
#3220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change we would be not adding `__init__.py` files for `site-packages` directories due to an oversight in how the root directory is handled. As user has reported, we should do this to be backwards compatible. Fixes bazel-contrib#3038
This was referenced Aug 27, 2025
Closed
Collaborator
|
This is really weird. I can't make sense how this would fix the described behavior, nor how the existing code results in the described behavior. I'll take further convo to the issue. |
Collaborator
Author
|
I wrote it when it was already late, let me close it as I think it is not appropriate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change we would be not adding
__init__.pyfiles forsite-packagesdirectories due to an oversight in how the rootdirectory is handled. As user has reported, we should do this to be
backwards compatible.
Fixes #3038