Skip to content

fix: handle urls without release id format #3306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 29, 2025
Merged

fix: handle urls without release id format #3306

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b4a7a05
fix: handle urls without release id format
rickeylev Sep 29, 2025
d364434
address review comment
rickeylev Sep 29, 2025
baee4df
add test
rickeylev Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion python/versions.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1045,7 +1045,13 @@ def get_release_info(platform, python_version, base_url = DEFAULT_RELEASE_BASE_U
for u in url:
p, _, _ = platform.partition(FREETHREADED)

release_id = int(u.split("/")[-2])
# Assume an unknown release_id is a newer url format
release_id = 99999999
url_parts = u.split("/")
if len(url_parts) >= 2:
maybe_release_id = url_parts[-2]
if maybe_release_id.isdigit():
release_id = int(maybe_release_id)

if FREETHREADED.lstrip("-") in platform:
build = "{}+{}-full".format(
Expand Down