Skip to content

Conversation

rickeylev
Copy link
Collaborator

The release tool wasn't determining the next version correctly because it was
in the wrong directory when that logic ran. To fix, chdir before that logic kicks off.

@rickeylev rickeylev requested a review from aignas as a code owner October 12, 2025 02:59
@rickeylev rickeylev enabled auto-merge October 12, 2025 02:59
Copy link
Contributor

Summary of Changes

Hello @rickeylev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the internal release tool where it failed to correctly determine the next release version due to an incorrect working directory context. The fix involves reordering a directory change operation to ensure the versioning logic executes from the correct workspace root. Additionally, comprehensive unit tests have been introduced to validate the determine_next_version function's behavior under various conditions, significantly improving the robustness of the release process.

Highlights

  • Fix Release Versioning: The internal release tool now correctly determines the next version by ensuring the working directory is set to the workspace root before the version determination logic is executed. This resolves an issue where the tool was operating from an incorrect directory.
  • Improved Test Coverage: New unit tests have been added for the determine_next_version function, covering various scenarios such as the absence of version markers, the presence of only patch markers, only feature markers, and both types of markers. These tests ensure the versioning logic behaves as expected.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses a bug in the release tool where the working directory was changed too late, causing an incorrect version determination. Moving the os.chdir call to the beginning of the main function is the right solution, ensuring that all subsequent operations run from the correct workspace root. The addition of the DetermineNextVersionTest class with its comprehensive test cases is excellent; it thoroughly validates the versioning logic under various conditions and improves the overall robustness of the script. The changes are well-implemented and the new tests provide great coverage.

@rickeylev rickeylev added this pull request to the merge queue Oct 12, 2025
Merged via the queue into bazel-contrib:main with commit 8069fa5 Oct 12, 2025
4 checks passed
@rickeylev rickeylev deleted the fix.release.version.logic branch October 12, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants