Skip to content

Conversation

aignas
Copy link
Collaborator

@aignas aignas commented Oct 13, 2025

As requested in #3340, this adds a functional test for it all.

Tests for #3339

As requested in bazel-contrib#3340, this adds a functional test for it all.

Tests for bazel-contrib#3339
@aignas aignas requested a review from rickeylev as a code owner October 13, 2025 01:07
Copy link
Contributor

Summary of Changes

Hello @aignas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses the need for functional testing of .pth files within virtual environments, as identified in issues #3340 and #3339. It introduces a new test case that ensures Python modules specified through .pth files are correctly discovered and importable when virtual environment site packages are active, thereby enhancing the robustness of the virtual environment management.

Highlights

  • New Functional Test for .pth Files: A new functional test has been introduced to verify the correct handling and import of modules defined via .pth files within virtual environments.
  • Expanded Test Coverage: The existing py_reconfig_test now includes a new py_library dependency, nested_with_pth, which specifically uses a .pth file to define a module path.
  • Test Assertion Added: The bin.py test file has been updated to assert that the nested_with_pth module can be successfully imported when venvs_site_packages is enabled, confirming .pth file functionality.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a functional test for .pth file handling in venvs, which is a great addition. The test setup is correct and covers the intended scenario. I've suggested a couple of minor improvements to make the test more robust by adding content to the test module and asserting it, which is a pattern used in other tests in this file. Otherwise, the changes look good.

aignas and others added 2 commits October 13, 2025 10:14
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…sted_sdk/nested_with_pth/__init__.py

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@rickeylev rickeylev enabled auto-merge October 13, 2025 02:13
@rickeylev rickeylev added this pull request to the merge queue Oct 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 14, 2025
@aignas aignas added this pull request to the merge queue Oct 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 14, 2025
@aignas aignas added this pull request to the merge queue Oct 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 14, 2025
@rickeylev rickeylev added this pull request to the merge queue Oct 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 14, 2025
@rickeylev rickeylev added this pull request to the merge queue Oct 14, 2025
Merged via the queue into bazel-contrib:main with commit 8f64e2c Oct 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants