-
-
Notifications
You must be signed in to change notification settings - Fork 636
chore(toolchain): use the last build and add 3.15.0a1 #3357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
TODO: - [ ] Discuss if we should release it together with the 1.7 release, if yes, I'll amend the changelog. It contains a bugfix for the 3.13.8, so there is value there.
Summary of ChangesHello @aignas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Python toolchain configuration to incorporate the latest available builds for several existing Python versions and introduces support for the new Python 3.15.0a1 alpha release. These changes ensure that the project leverages the most recent bug fixes and features from the Python ecosystem, maintaining an up-to-date development environment. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Python toolchain versions to use the latest builds, reflected by the change in the build date in the URLs and updated SHA256 hashes. It also introduces support for Python 3.15.0a1
and updates version 3.13.8
to 3.13.9
. While the changes are mostly correct, I've found a critical issue where the MINOR_MAPPING
for Python 3.13 was not updated to point to the new 3.13.9
version, which could lead to build failures.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the BCR release is stuck, I think it's fine to put this in 1.7 and do an rc1
/gemini adjust the changelog of 1.7 to mention the new versions and the release. |
Hi @aignas, I understand you're asking me to adjust the changelog. As an AI, I'm unable to directly modify files or perform actions like updating the changelog. My role is to provide feedback and suggestions. The summary I provided earlier in this conversation details the Python version updates, including the new Python 3.15.0a1 addition and the upgrade of Python 3.13.8 to 3.13.9. You can use that information as a basis to manually update the If you intended to invoke one of my supported commands, please refer to the |
Updating the toolchain versions to fix a bug in
3.13.8
. This will makethe release better to everyone.