-
-
Notifications
You must be signed in to change notification settings - Fork 636
doc: Fix pip.default
arguments in multi-platform example
#3358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Fix pip.default
arguments in multi-platform example
#3358
Conversation
Summary of ChangesHello @hartikainen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes the argument names in the pip.default
examples in the multi-platform documentation, changing os
and cpu
to os_name
and arch_name
respectively. However, the examples are syntactically incorrect as they are missing commas between arguments. I've added comments with suggestions to fix this and also to improve the consistency of argument ordering for better readability.
pip.default
arguments in multi-platform examplepip.default
arguments in multi-platform example
Thanks for the doc fix! |
I was playing around with the multi-platform PyPI example and noticed that the
pip.default
arguments were wrong.