chore: make gazelle bcr tests compatible with bcr presubmit environment #3365
Conversation
Summary of ChangesHello @rickeylev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the configuration for Gazelle's BCR presubmit tests to adapt to recent changes in BCR's archive extraction mechanism. The primary goal is to restore the functionality of these tests by relocating a key example module and adjusting dependency resolution, specifically for Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the Gazelle BCR tests to be compatible with recent changes in the BCR presubmit environment. The changes involve moving the test module into the gazelle directory and updating CI configurations accordingly. A key change is disabling the local rules_python override during BCR presubmits, ensuring the test uses a version from the Bazel Central Registry. The changes are logical and well-explained. I have one suggestion to improve the robustness of a shell command in the CI configuration.
2 participants
BCR recently changed how it extracts archives in its presubmits: instead of extracting
the whole archive, only the specified portion (
gazelle/in this case) is extracted.This broke the gazelle tests because they reference files above the gazelle directory.
To fix, move the module it runs as a test under the gazelle directory.
Because the test module also refers to rules_python, which is above the gazelle
directory, the bcr presubmit has disable that override using
--override_module.This means, going forward, the gazelle module, when bcr tests it, will use the
version in the MODULE file (rather than the vendored copy).
Fixes #3364