chore(deps): update rules_cc and protobuf versions #3367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickeylev
reviewed
Oct 17, 2025
| py_repositories() | ||
|
|
||
| # Needed for rules_cc 0.2.10 | ||
| load("@bazel_features//:deps.bzl", "bazel_features_deps") |
There was a problem hiding this comment.
Instead of copy/pasting this same setup to every downstream workspace, create a second setup function and load and call that.
python/repositories_deps.bzl
which does the 4 lines
| - "--noenable_bzlmod" | ||
| - "--build_tag_filters=-integration-test" | ||
| # recent abseil-cpp requires C++17 which is not used by default in Bazel 7 | ||
| - "--cxxopt=-std=c++17" |
There was a problem hiding this comment.
Can you explain a bit more about this? I'm guessing this is coming from protobuf?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rules_ccto 0.2.10protobufto 33.0 which has load statements forrules_ccneeded for bazel 9