feat: Introduces a new target_tar_toolchain_type #65
Conversation
Introduces target_type toolchain alongside the existing exec-based type, allowing tar operations to be resolved based on target platform. Also adds resolved_target_toolchain for direct toolchain access in genrules. Includes test to validate functionality.
sfc-gh-dbieliaiev
force-pushed
the
dbieliaiev-target-tar-toolchain
branch
from
d218fb3 to
e3d204c
Compare
|
sfc-gh-dbieliaiev
changed the title
|
The CI failure is unrelated, but please add |
|
@fmeum Thanks, already done |
fmeum
left a comment
fmeum
left a comment
There was a problem hiding this comment.
We could call target_type runtime_type, but I'm not sure whether that's clearly better.
We may need to update awk to get past the outage.
Although I prefer target type more as it illustrates direct connection with |
|
Yeah, let's keep |
Hi @thesayyn, @alexeagle. I'd like to help solve the cross-platform remote execution issue described in [#769](#769), which significantly affects us. I see this is connected to the fundamental Bazel limitation described in [bazelbuild/bazel#19645](bazelbuild/bazel#19645). I've noticed that a similar issue was addressed for crane and yq toolchains in [#590](#590), but the same transition-based solution for tar toolchain ([#762](#762)) got stuck because it doesn't work well in other cases. ## Proposal I'm suggesting to use target_toolchain which was [recently implemented](bazel-contrib/tar.bzl#65) instead of toolchain to determine it correctly. As a prerequisite we need to migrate to tar.bzl. ## Changes summary 1. tar.bzl was used instead of `aspect_bazel_lib/tar.bzl` 2. target toolchain was used instead of toolchainl.
3 participants
This PR is a follow-up to bazel-contrib/bazel-lib#1180 which is supposed to help with the issue described in bazel-contrib/rules_oci#769. The description of the issue and proposal are in bazel-contrib/rules_oci#844 PR.
CC @alexeagle @fmeum