Emit canonical labels if needed in pkg_name_from_label
#447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously resulted in errors such as: ``` Traceback (most recent call last): File "/private/var/tmp/_bazel_fmeum/5d22c23119063f77cfcdafc5f5d52f01/external/toolchains_llvm+/toolchain/internal/configure.bzl", line 141, column 66, in llvm_config_impl sysroot_paths_dict, sysroot_labels_dict = _sysroot_paths_dict( File "/private/var/tmp/_bazel_fmeum/5d22c23119063f77cfcdafc5f5d52f01/external/toolchains_llvm+/toolchain/internal/sysroot.bzl", line 76, column 53, in sysroot_paths_dict path = _canonical_dir_path(str(rctx.path(label).dirname)) Error in path: Unable to load package for @@[unknown repo 'toy-toolchain++toy_sysroot+sysroot_amd64_ubuntu' requested from @@toolchains_llvm+]//:BUILD.bazel: The repository '@@[unknown repo 'toy-toolchain++toy_sysroot+sysroot_amd64_ubuntu' requested from @@toolchains_llvm+]' could not be resolved: No repository visible as '@toy-toolchain++toy_sysroot+sysroot_amd64_ubuntu' from repository '@@toolchains_llvm+ ```
Member
Author
rrbutani
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously resulted in errors such as: